Open
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
ZuseZ4
commented
Jan 25, 2026
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
2 times, most recently
from
d9def93 to
4f29cbe
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
2 times, most recently
from
014d61d to
6b45680
Compare
rustbot
added
S-waiting-on-review
Member
Author
|
I don't think jieyouxu will want to review this part of rustc. |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
6b45680 to
1c28bd8
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
2 times, most recently
from
c310bf7 to
b2b51e4
Compare
Member
Author
|
@rustbot reroll |
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
b2b51e4 to
3fb0092
Compare
Collaborator
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
3fb0092 to
446bd1d
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
spurious failure, cc @jieyouxu |
Member
|
There's an issue at #93784. |
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
446bd1d to
d8a440f
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
d8a440f to
544a019
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Zalathar
reviewed
Feb 7, 2026
Member
|
The individual commits seem like they don't have a reason to be separate, so please squash them. |
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
544a019 to
b28b622
Compare
Member
Author
|
One of the commits had gotten lost over one of the last rebases. I've re-added it and fused them. |
nnethercote
approved these changes
Feb 8, 2026
Contributor
|
r=me, just one question about the |
…t_all_rtls into global ctor
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
b28b622 to
6de0591
Compare
Member
Author
|
@bors r=nnethercote rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 8, 2026
…thercote Cleanup offload datatransfer There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back. At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage. cc @jdoerfert @kevinsala r? compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back.
At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage.
cc @jdoerfert @kevinsala
r? compiler